Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit deps licenses; cargo.lock; toolchain #890

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Audit deps licenses; cargo.lock; toolchain #890

wants to merge 5 commits into from
+88 −1,429

Conversation

maksimryndin
Copy link

@maksimryndin maksimryndin commented Nov 14, 2024 •
edited by ohad-starkware
Loading

Hey guys! Thanks for a brilliant work!

Some small improvements:

  • cargo deny to audit security vulnerabilities, license issues, dependencies issues
  • remove Cargo.lock as it is a library
  • remove WORKSPACE file (I believe a remnant from Stone :))
  • remove toolchain in scripts and ci cargo commands (as the `rust-toolchain.toml" already specifies it)

@reviewable-StarkWare
Copy link

This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maksimryndin @reviewable-StarkWare